MrMonopoly/raylib
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Enhance OpenURL function to prevent command injection and restrict protocols

Browse Source
This commit is contained in:
saku0512 2026-04-26 12:43:58 +09:00
parent 0f98d78a67
commit a348c9dc82
No known key found for this signature in database
GPG Key ID: 945E2D5D5346343C
9 changed files with 139 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/platforms/rcore_android.c
View File

@ -51,6 +51,8 @@
#include <errno.h> // Required for: error types
#include <jni.h> // Required for: JNIEnv and JavaVM [Used in OpenURL() and GetCurrentMonitor()]
#include <string.h>
#include <ctype.h> // Required for: isspace()
#include <EGL/egl.h> // Native platform windowing system interface
@ -670,9 +672,20 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
JNIEnv *env = NULL;
JavaVM *vm = platform.app->activity->vm;
(*vm)->AttachCurrentThread(vm, &env, NULL);

14
src/platforms/rcore_desktop_glfw.c
View File

@ -105,6 +105,7 @@
#endif
#include <stddef.h> // Required for: size_t
#include <ctype.h> // Required for: isspace()
//----------------------------------------------------------------------------------
// Types and Structures Definition
@ -1191,9 +1192,20 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
char *cmd = (char *)RL_CALLOC(strlen(url) + 32, sizeof(char));
#if defined(_WIN32)
sprintf(cmd, "explorer \"%s\"", url);

14
src/platforms/rcore_desktop_rgfw.c
View File

@ -169,6 +169,7 @@ extern "C" {
#endif
#include <stdbool.h>
#include <ctype.h> // Required for: isspace()
//----------------------------------------------------------------------------------
// Types and Structures Definition
@ -1179,9 +1180,20 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code on target platform
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
char *cmd = (char *)RL_CALLOC(strlen(url) + 32, sizeof(char));
#if defined(_WIN32)
sprintf(cmd, "explorer \"%s\"", url);

21
src/platforms/rcore_desktop_sdl.c
View File

@ -91,6 +91,9 @@
#define SCANCODE_MAPPED_NUM 232
#include <string.h>
#include <ctype.h> // Required for: isspace()
//----------------------------------------------------------------------------------
// Types and Structures Definition
//----------------------------------------------------------------------------------
@ -1289,8 +1292,22 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
else SDL_OpenURL(url);
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
SDL_OpenURL(url);
}
}
//----------------------------------------------------------------------------------

16
src/platforms/rcore_desktop_win32.c
View File

@ -70,6 +70,7 @@
#include <versionhelpers.h>
#include <malloc.h> // Required for alloca()
#include <ctype.h> // Required for: isspace()
#if !defined(GRAPHICS_API_OPENGL_SOFTWARE)
#include <GL/gl.h>
@ -1254,9 +1255,20 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code on target platform
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
char *cmd = (char *)RL_CALLOC(strlen(url) + 32, sizeof(char));
sprintf(cmd, "explorer \"%s\"", url);
int result = system(cmd);
@ -2271,4 +2283,4 @@ static bool IsWglExtensionAvailable(HDC hdc, const char *extension)
}
return result;
}
}

16
src/platforms/rcore_memory.c
View File

@ -52,6 +52,9 @@
#include <fcntl.h>
#endif
#include <string.h>
#include <ctype.h> // Required for: isspace()
//----------------------------------------------------------------------------------
// Types and Structures Definition
//----------------------------------------------------------------------------------
@ -384,9 +387,20 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code on target platform
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
char *cmd = (char *)RL_CALLOC(strlen(url) + 32, sizeof(char));
sprintf(cmd, "explorer \"%s\"", url);
int result = system(cmd);

16
src/platforms/rcore_template.c
View File

@ -48,6 +48,9 @@
// TODO: Include the platform specific libraries
#include <string.h>
#include <ctype.h> // Required for: isspace()
//----------------------------------------------------------------------------------
// Types and Structures Definition
//----------------------------------------------------------------------------------
@ -357,9 +360,20 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code on target platform
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
// TODO: Load url using default browser
}
}

20
src/platforms/rcore_web.c
View File

@ -50,6 +50,8 @@
#include <emscripten/html5.h> // Emscripten HTML5 library
#include <sys/time.h> // Required for: timespec, nanosleep(), select() - POSIX
#include <string.h>
#include <ctype.h> // Required for: isspace()
//----------------------------------------------------------------------------------
// Defines and Macros
@ -997,8 +999,22 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code on target platform
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
else emscripten_run_script(TextFormat("window.open('%s', '_blank')", url));
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
emscripten_run_script(TextFormat("window.open('%s', '_blank')", url));
}
}
//----------------------------------------------------------------------------------

20
src/platforms/rcore_web_emscripten.c
View File

@ -45,6 +45,8 @@
#include <emscripten/html5.h> // Emscripten HTML5 library
#include <sys/time.h> // Required for: timespec, nanosleep(), select() - POSIX
#include <string.h>
#include <ctype.h> // Required for: isspace()
//----------------------------------------------------------------------------------
// Defines and Macros
@ -974,8 +976,22 @@ double GetTime(void)
void OpenURL(const char *url)
{
// Security check to (partially) avoid malicious code on target platform
if (strchr(url, '\'') != NULL) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'] character");
else emscripten_run_script(TextFormat("window.open('%s', '_blank')", url));
if ((strchr(url, '\'') != NULL) || (strchr(url, '\"') != NULL)) TRACELOG(LOG_WARNING, "SYSTEM: Provided URL could be potentially malicious, avoid [\'\"] characters");
else
{
// Restriction: Only allow http:// and https:// protocols
const char *p = url;
while (*p && isspace((unsigned char)*p)) p++;
char protocol[9] = { 0 };
for (int i = 0; (i < 8) && p[i]; i++) protocol[i] = (char)tolower((unsigned char)p[i]);
if ((strncmp(protocol, "http://", 7) != 0) && (strncmp(protocol, "https://", 8) != 0))
{
TRACELOG(LOG_WARNING, "SYSTEM: Provided URL protocol is not allowed; only http:// and https:// are permitted");
return;
}
emscripten_run_script(TextFormat("window.open('%s', '_blank')", url));
}
}
//----------------------------------------------------------------------------------